Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

[PORT] Ethereal crystalization upon death - #20564

Merged
Moltijoe merged 5 commits into
yogstation13:masterfrom
Moltijoe:EtherealRevive
Oct 19, 2023
Merged

[PORT] Ethereal crystalization upon death#20564
Moltijoe merged 5 commits into
yogstation13:masterfrom
Moltijoe:EtherealRevive

Conversation

@Moltijoe

@Moltijoe Moltijoe commented Oct 8, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

no clue what PRs this is from, i just ripped it out of the tgcodebase
tartu found it for me
tgstation/tgstation#57225

Why is this good for the game?

Gives ethereals an interesting mechanic that realistically only helps in silly deaths rather than affecting antag balance

Testing

image
image

Spriting

colour changes to match the ethereal
anim
crystal

🆑 Qustinnus, Kryson, uglykoala, Ghost, @Moltijoe
rscadd: Ethereals now crystallize upon death, reviving after a delay
soundadd: Sounds for crystalization starting, finishing, and being interrupted
imageadd: Sprites for ethereal crystallization
/:cl:

@Moltijoe
Moltijoe requested review from a team as code owners October 8, 2023 02:25
@Yogbot-13 Yogbot-13 added DME Edit This PR affects the yogstation.DME file Feature This adds new content to the game Sprites This PR has spriting changes labels Oct 8, 2023
@cowbot92

cowbot92 commented Oct 8, 2023

Copy link
Copy Markdown
Contributor

Wait this is actually badass??

@github-actions github-actions Bot added the Sound This PR changes audio files label Oct 8, 2023
@ManofSan

ManofSan commented Oct 8, 2023

Copy link
Copy Markdown

ethereal mains will rise

ToasterBiome
ToasterBiome suggested changes Oct 8, 2023
View reviewed changes

@ToasterBiome ToasterBiome left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make the BRUTE_DAMAGE_REQUIRED_TO_STOP_CRYSTALIZATION a way way way way lower amount if the user isn't a ethereal

@Moltijoe
Moltijoe requested a review from ToasterBiome October 8, 2023 04:10
@ShoziOffical

ShoziOffical commented Oct 8, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

how can you not find the pr tgstation/tgstation#57225
credit them

@Moltijoe

Moltijoe commented Oct 8, 2023

Copy link
Copy Markdown
Contributor Author

how can you not find the pr tgstation/tgstation#57225

apparently searching "ethereal" and "crystallize" doesn't bring it up for some reason

@azzzertyy

azzzertyy commented Oct 10, 2023

Copy link
Copy Markdown
Contributor

not sure how i feel about the brain trauma, punishes ethereal players for something they cant exactly control.
maybe if you could decide to not let yourself get crystallized on death and instead just turn into a normal corpse?

@Moltijoe

Moltijoe commented Oct 10, 2023

Copy link
Copy Markdown
Contributor Author

not sure how i feel about the brain trauma, punishes ethereal players for something they cant exactly control. maybe if you could decide to not let yourself get crystallized on death and instead just turn into a normal corpse?

it's a 5 minute delay to crystalization, at that point, who knows how long you're gonna stay dead

@Moltijoe Moltijoe added the Balance Council Approved This PR was approved by the Balance Council. label Oct 13, 2023
@MajManatee MajManatee added the Awaiting - Action - HD Awaiting action from Jamie label Oct 17, 2023
@ToasterBiome
ToasterBiome requested a review from cuackles October 18, 2023 03:59
@ToasterBiome ToasterBiome removed the Awaiting - Action - HD Awaiting action from Jamie label Oct 18, 2023
@ToasterBiome
ToasterBiome requested a review from a team October 18, 2023 03:59
@MajManatee MajManatee added the Awaiting - Action - Sprite Review Awaiting sprite review from sprite maintainers label Oct 18, 2023
@Moltijoe
Moltijoe merged commit 571e794 into yogstation13:master Oct 19, 2023
Yogbot-13 added a commit that referenced this pull request Oct 19, 2023
@Yogbot-13
Automatic changelog generation #20564 [ci skip]
0fdde3e
@Moltijoe
Moltijoe deleted the EtherealRevive branch October 19, 2023 12:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@ToasterBiome ToasterBiome ToasterBiome approved these changes
@cuackles cuackles cuackles approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Awaiting - Action - Sprite Review Awaiting sprite review from sprite maintainers Balance Council Approved This PR was approved by the Balance Council. DME Edit This PR affects the yogstation.DME file Feature This adds new content to the game Sound This PR changes audio files Sprites This PR has spriting changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@Moltijoe @cowbot92 @ManofSan @ShoziOffical @azzzertyy @ToasterBiome @cuackles @Yogbot-13 @MajManatee